Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple connect/disconnect in NodeBreakerVoltageLevel (#285) #324

Merged
merged 2 commits into from
May 31, 2021

Conversation

sebalaig
Copy link
Contributor

@sebalaig sebalaig commented May 28, 2021

Signed-off-by: Sébastien LAIGRE [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#285

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@sebalaig sebalaig self-assigned this May 28, 2021
@sebalaig sebalaig requested a review from mathbagu May 28, 2021 11:41
@mathbagu mathbagu added the bug Something isn't working label May 31, 2021
@sebalaig sebalaig changed the title Fix multiple connect/disconnect in NodeBreakerVoltageLevel (#285) WIP: Fix multiple connect/disconnect in NodeBreakerVoltageLevel (#285) May 31, 2021
…nwanted topology change (#285)

Signed-off-by: Sébastien LAIGRE <[email protected]>
@sebalaig sebalaig force-pushed the issue285-fix-connect-disconnect-nbk branch from dc6aa80 to 6c8bce1 Compare May 31, 2021 14:12
@sebalaig sebalaig changed the title WIP: Fix multiple connect/disconnect in NodeBreakerVoltageLevel (#285) Fix multiple connect/disconnect in NodeBreakerVoltageLevel (#285) May 31, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

@mathbagu mathbagu merged commit 6b49d25 into integration/v1.5.0 May 31, 2021
@mathbagu mathbagu deleted the issue285-fix-connect-disconnect-nbk branch May 31, 2021 19:28
mathbagu pushed a commit that referenced this pull request Nov 30, 2021
…nwanted topology change (#285) (#324)

Signed-off-by: Sébastien LAIGRE <[email protected]>
mathbagu pushed a commit that referenced this pull request Jan 10, 2022
…nwanted topology change (#285) (#324)

Signed-off-by: Sébastien LAIGRE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: ready-to-be-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeBreakerVoltageLevel connect may change the topology as unwanted side effect
2 participants